search

jupyter / tmpnb

Creates temporary Jupyter Notebook servers using Docker containers. [DEPRECATED - See BinderHub project]
https://github.com/jupyterhub/binderhub
BSD 3-Clause "New" or "Revised" License
528 stars 123 forks source link

Modification of dockworker.py to eliminate deprecation warning #273

Closed misolietavec closed 7 years ago

misolietavec commented 7 years ago

After starting tmpnb container, this warning message is issued (seen by: docker logs tmpnb) ... UserWarning: docker.utils.create_host_config() is deprecated. Please use Client.create_host_config() instead I see it in default version (1.7.2 ) of docker-py specified in Dockerfile and also in newest version 1.10.6 (from pypi). By proposed simple change in dockworker.py this warning can be elliminated.

I also added files *~ (produced as backup files in e.g. joe editor) to .gitignore thinking that it can do no harm.

rgbkrk commented 7 years ago

For your own local editor configuration it's best to have a global gitignore: https://help.github.com/articles/ignoring-files/