jupyter / tmpnb

Creates temporary Jupyter Notebook servers using Docker containers. [DEPRECATED - See BinderHub project]
https://github.com/jupyterhub/binderhub
BSD 3-Clause "New" or "Revised" License
528 stars 123 forks source link

Package docker-py versus docker, what to do in the future? #274

Open misolietavec opened 7 years ago

misolietavec commented 7 years ago

In this repository, we use docker-py (in requirements.txt, or in Dockerfile-alpine). This is older package, last version 1.10.6 on pypi is from 2016-11-02. The newer package is called docker (newest ver. 2.2.1 from 2017-03-28). Besides the ambiguous name, docker package is incompatible with docker-py.

I cannot find the list of incompatible changes, maybe someone will have better luck. I tried to use docker instead of docker-py in Dockerfile-alpine and got a lengthy trace of errors, ending with such "suggestion": TypeError: 'ContainerCollection' object is not callable. You might be trying to use the old (pre-2.0) API - use docker.APIClient if so.

If developers decide to use docker package in the future, the codebase here needs to be adapted. Maybe, this is not a big task, but I am unable to do it.

misolietavec commented 7 years ago

I apologize, the breaking changes (and new features) from version 1.10.6 (docker-py) to 2.0.0 (docker) can be found at docker-py documentation. The relevant changes, I think, are: