jupyter / try.jupyter.org

Try Jupyter!
https://try.jupyter.org
BSD 3-Clause "New" or "Revised" License
10 stars 13 forks source link

try.jupyter.org should redirect to HTTPS if loaded on HTTP #15

Closed rgbkrk closed 7 years ago

rgbkrk commented 8 years ago

If loaded over HTTP, the iframe for tmpnb will not load because it violates the content security policy:

screen shot 2016-07-26 at 3 12 25 pm
Carreau commented 7 years ago

@fperez this is already an opened issue.

fperez commented 7 years ago

Thanks, @Carreau! @rgbkrk, is this an easy fix? I'm not up to speed on how tmpnb/tryjupyter is deployed, but right now this failure mode is going to make it look fully broken to a lot of users who simply try the naive thing of hitting try.jupyter.org without further qualification...

rgbkrk commented 7 years ago

The notebook server containers needed to be changed to have a more open content security policy in docker-demo-images. It looks like this was already changed, and the build went out. Perhaps it was an old node still in rotation or something changed with the machine I'm on being on the latest Chrome and OS X macOS release - it now works flawlessly for me.

alanhdu commented 7 years ago

Hi!

I'm noticing this problem with Firefox (51a2 developer edition) on Ubuntu 16.04.

https://try.jupyter.org works fine, but when I go to http://try.jupyter.org, I get a big: image

This might be a Firefox-only problem -- Chrome redirects from http to https without any problems.

alanhdu commented 7 years ago

Hi again! Sorry to bug you about this, but I wanted to check whether there was any updates here. I'm going to be hosting a bunch of workshops in the next couple of weeks, and it'd be great to get this resolved.

It's not super urgent because the http -> https redirection is working perfectly for http://tmpnb.org (maybe the only thing to do here is to update / redeploy http://try.jupyter.org?), but it is a bit of a papercut.

minrk commented 7 years ago

@alanhdu sorry for the delay. It should be fixed now by this.