search

jupytercad / JupyterCAD-FreeCAD

BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

Add freecad icon #21

Closed martinRenou closed 2 hours ago

martinRenou commented 3 days ago

Fix https://github.com/jupytercad/JupyterCAD-FreeCAD/issues/14

Screenshot From 2024-11-29 15-53-57

SylvainCorlay commented 3 days ago

I think the highlighted icon should probably become white like other file icons.

martinRenou commented 8 hours ago

Actually I'm not sure I agree 😆

Screenshot From 2024-12-02 11-02-17

SylvainCorlay commented 2 hours ago

Actually I'm not sure I agree 😆

If the F-shaped central area takes the background color (selection blue) when highlighted, that could work.

martinRenou commented 2 hours ago

https://github.com/user-attachments/assets/088f5554-0e58-463e-b11c-023fdafe8013

martinRenou commented 2 hours ago

It looks like the CI cannot be trusted anymore, I'll just merge

SylvainCorlay commented 2 hours ago

It looks like the CI cannot be trusted anymore, I'll just merge

💯 we should never trust CI 😆