Remove the guidata option

jupytercad / JupyterCAD

A JupyterLab extension for 3D geometry modeling

https://jupytercad.readthedocs.io

BSD 3-Clause "New" or "Revised" License

118 stars 15 forks source link

Remove the guidata option #413

Closed arjxn-py closed 2 weeks ago

arjxn-py commented 2 weeks ago

Should potentially close #410

github-actions[bot] commented 2 weeks ago

Preview PR at appsharing.space

arjxn-py commented 2 weeks ago

Bot please update snapshots!

arjxn-py commented 2 weeks ago

I've not looked too deeply into the implementation yet, but it looks like this PR is breaking the some logic upon the application of a boolean operator. When creating two initial shapes, then applying a cut operator on them, the two initial shapes are not set hidden anymore. Also when trying to hide them manually from the left panel seems to not work reliably.

I noticed this after your comment, i'm looking into why this is happening. Thanks for pointing it out.

trungleduc commented 2 weeks ago

color-error This error here is related?

arjxn-py commented 2 weeks ago

This error here is related?

Might be related to #397, have to look into it. Thanks a lot for letting me know

arjxn-py commented 2 weeks ago

Bot please update snapshots!

arjxn-py commented 2 weeks ago

This error here is related?

Might be related to #397, have to look into it. Thanks a lot for letting me know

Hi @trungleduc, I tried reproducing this on my end locally but it seems like it works fine for me. However I'd want to confirm a couple of things -

Did you select any object before clicking intersection? (As it takes the color of that object)
Do you also get commands.js:262 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'value') error when you try to do intersection with no obect or a single object? (This should be a valid error but maybe we could handle it better.)

arjxn-py commented 2 weeks ago

https://github.com/user-attachments/assets/5149bc12-ca48-44b9-aced-3a7978d6f9c3

Visibility toggling works fine
Only result is visible after operation

trungleduc commented 2 weeks ago

yeah, I can not reproduce it anymore, thanks for double-checking it!

trungleduc commented 2 weeks ago

we should update https://github.com/jupytercad/JupyterCAD-FreeCAD since it also uses the guidata section

arjxn-py commented 2 weeks ago

we should update https://github.com/jupytercad/JupyterCAD-FreeCAD since it also uses the guidata section

Yes, I'll be on that next. Thank You :)

arjxn-py commented 2 weeks ago

Thanks! Let's make an alpha release of this so we can start updating jupytercad-freecad

Sounds good, should I wait for the release to open a PR on jupytercad-freecad?

martinRenou commented 2 weeks ago

That will be easier for you that way 👍🏽

martinRenou commented 2 weeks ago

It's out https://github.com/jupytercad/JupyterCAD/releases/tag/v3.0.0a0 You can install it with pip: https://pypi.org/project/jupytercad/3.0.0a0/

arjxn-py commented 2 weeks ago

It's out https://github.com/jupytercad/JupyterCAD/releases/tag/v3.0.0a0 You can install it with pip: https://pypi.org/project/jupytercad/3.0.0a0/

Best! Thanks @martinRenou 🚀