Update `ThreeJS` - Githubissues

jupytercad / JupyterCAD

A JupyterLab extension for 3D geometry modeling

https://jupytercad.readthedocs.io

BSD 3-Clause "New" or "Revised" License

118 stars 15 forks source link

Update `ThreeJS` #418

Closed arjxn-py closed 2 days ago

arjxn-py commented 2 weeks ago

Currently a draft, but open for reviews Related to #344

arjxn-py commented 2 weeks ago

The changes doesn't look very pretty at the moment:

We've this plane visible which should be there but not be visible afaik
The colors of the model are a bit dimmed (the set color on the cube is sharp yellow, Maybe a lightning issue?)

Considering this a start, the next thing I plan are -

[ ] to get rid of some of @ts-ignores in the mainview
[ ] Update threeJS typings maybe
[ ] Identify above issues and resolve them

github-actions[bot] commented 2 weeks ago

Preview PR at appsharing.space

martinRenou commented 2 weeks ago

Thanks for starting this!

I believe the black mesh we are seeing here is the this._clippingPlaneMesh mesh object from the 3D view. IIRC it is not supposed to be visible, this one should only be used for the filling the gaps when clipping is enabled. I can have a deeper look at this later if you need.

arjxn-py commented 2 weeks ago

I believe the black mesh we are seeing here is the this._clippingPlaneMesh mesh object from the 3D view. IIRC it is not supposed to be visible, this one should only be used for the filling the gaps when clipping is enabled. I can have a deeper look at this later if you need.

yes, i've seen this plane in the mainview. I shall try to look into it and also see if it can be fixed by making it not visible or something. I'll be happy to follow up on the same in case I would need you to have to take a look into the same :)

github-actions[bot] commented 1 week ago

Integration tests repot: appsharing.space

arjxn-py commented 6 days ago

Bot please update snapshots.

martinRenou commented 3 days ago

Bot please update snapshots!

arjxn-py commented 3 days ago

Bot please update snapshots!

Update Galata References workflow is failing everytime xref: #438, I'll be happy to try on to fix it

martinRenou commented 3 days ago

Update Galata References workflow is failing everytime xref: https://github.com/jupytercad/JupyterCAD/issues/438, I'll be happy to try on to fix it

I commented there. Would you be able to try and fix the bot so we can get this PR green?

arjxn-py commented 3 days ago

I commented there. Would you be able to try and fix the bot so we can get this PR green?

Thanks a lot 🚀 Yes, I'm on it.

martinRenou commented 3 days ago

Bot please update snapshots!!

martinRenou commented 3 days ago

Neat! I'll trigger the CI