search

jupytercad / JupyterCAD

A JupyterLab extension for 3D geometry modeling
https://jupytercad.github.io/JupyterCAD
BSD 3-Clause "New" or "Revised" License
135 stars 18 forks source link

Bump jupyter-collaboration v3 #429

Closed davidbrochart closed 2 months ago

github-actions[bot] commented 2 months ago

Preview PR at appsharing.space

davidbrochart commented 2 months ago

Failures seem to be relevant?

trungleduc commented 2 months ago

Failures seem to be relevant?

yes, are you able to add new object to the JCAD file?

davidbrochart commented 2 months ago

Yes.

trungleduc commented 2 months ago

Bumping Galata to the latest version might help

trungleduc commented 2 months ago

We need another pass on the UI test with the new Galata version. I'll work on it

github-actions[bot] commented 2 months ago

Integration tests repot: appsharing.space

trungleduc commented 2 months ago

@davidbrochart it's green now

davidbrochart commented 2 months ago

Nice, thanks! Do you think we should merge it, or make a final release of jupyter-collaboration v3?

trungleduc commented 2 months ago

I don't know about releasing jupyter-collaboration but i have no issue merging this PR.

davidbrochart commented 2 months ago

Yes I think we can merge in either case :+1: