search

jupytercad / JupyterCAD

A JupyterLab extension for collaborative 3D geometry modeling
https://jupytercad.github.io/JupyterCAD
BSD 3-Clause "New" or "Revised" License
139 stars 18 forks source link

refLength was not always updating #493

Closed martinRenou closed 1 month ago

martinRenou commented 1 month ago

The refLength update wasn't always done. This had the impact of eventually breaking the clipplane effect which depends on it.

github-actions[bot] commented 1 month ago

Integration tests repot: appsharing.space

github-actions[bot] commented 1 month ago

Preview PR at appsharing.space

trungleduc commented 1 month ago

Thanks @martinRenou

martinRenou commented 1 month ago

Bot please update snapshots

martinRenou commented 1 month ago

Some visual changes are not ok, putting as draft

martinRenou commented 1 month ago

Bot please update snapshots!

SylvainCorlay commented 1 month ago

Could this be the reason why the pointer "ball" was sometimes oversized / undersized?

martinRenou commented 1 month ago

Could this be the reason why the pointer "ball" was sometimes oversized / undersized?

Very likely yes. The pointer ball diameter should now stay roughly a tenth of the reference length.