search

jupytercad / JupyterCAD

A JupyterLab extension for collaborative 3D geometry modeling
https://jupytercad.github.io/JupyterCAD
BSD 3-Clause "New" or "Revised" License
139 stars 18 forks source link

Releaser fails with something related to jupyter-collaboration/jupyter-ydoc #512

Closed martinRenou closed 1 month ago

martinRenou commented 1 month ago

Publishing releases currently fails with:

$ jlpm clean && jlpm build:lib:prod && jlpm build:labextension
src/jcadplugin/plugins.ts(92,9): error TS2322: Type '() => JupyterCadDoc' is not assignable to type 'SharedDocumentFactory'.
  Type 'JupyterCadDoc' is not assignable to type 'YDocument<DocumentChange>'.
    Property 'onStateChanged' is protected but type 'YDocument<T>' is not a class derived from 'YDocument<T>'.
src/stepplugin/plugins.ts(61,9): error TS2322: Type '() => JupyterCadStepDoc' is not assignable to type 'SharedDocumentFactory'.
  Type 'JupyterCadStepDoc' is not assignable to type 'YDocument<DocumentChange>'.
    Property 'onStateChanged' is protected but type 'YDocument<T>' is not a class derived from 'YDocument<T>'.
src/stlplugin/plugins.ts(61,9): error TS2322: Type '() => JupyterCadStlDoc' is not assignable to type 'SharedDocumentFactory'.
  Type 'JupyterCadStlDoc' is not assignable to type 'YDocument<DocumentChange>'.
    Property 'onStateChanged' is protected but type 'YDocument<T>' is not a class derived from 'YDocument<T>'.
arjxn-py commented 1 month ago

@trungleduc it can be closed with #516

trungleduc commented 1 month ago

Yes.