search

jupytercad / JupyterCAD

A JupyterLab extension for collaborative 3D geometry modeling
https://jupytercad.github.io/JupyterCAD
BSD 3-Clause "New" or "Revised" License
139 stars 18 forks source link

Fix lighting issue #514

Closed arjxn-py closed 1 month ago

arjxn-py commented 1 month ago

https://github.com/user-attachments/assets/606d56d9-dccd-434b-bb4f-cb53c97290e8

trungleduc commented 1 month ago

what happens if we keep using the MeshPhongMaterial?

arjxn-py commented 1 month ago

what happens if we keep using the MeshPhongMaterial?

metalness & roughness properties doesn't seem to be there in MeshPhongMaterial

martinRenou commented 1 month ago

The standard material uses PBR so it's actually good we're switching to this!

trungleduc commented 1 month ago

what happens if we keep using the MeshPhongMaterial?

metalness & roughness properties doesn't seem to be there in MeshPhongMaterial

i know, but are they needed if we use zero decay? Could you post a screenshot of using MeshPhongMaterial?

arjxn-py commented 1 month ago

what happens if we keep using the MeshPhongMaterial?

metalness & roughness properties doesn't seem to be there in MeshPhongMaterial

i know, but are they needed if we use zero decay? Could you post a screenshot of using MeshPhongMaterial?

on it

github-actions[bot] commented 1 month ago

Integration tests repot: appsharing.space

github-actions[bot] commented 1 month ago

Preview PR at appsharing.space

arjxn-py commented 1 month ago

i know, but are they needed if we use zero decay? Could you post a screenshot of using MeshPhongMaterial?

https://github.com/user-attachments/assets/2d73d287-7a78-4022-85bd-3983ceb789c3

@trungleduc

trungleduc commented 1 month ago

Thanks, indeed it looks better with the MeshStandardMaterial