After applying an operator the boundinx boxes of the inputs are still visible

jupytercad / JupyterCAD

A JupyterLab extension for collaborative 3D geometry modeling

https://jupytercad.github.io/JupyterCAD

BSD 3-Clause "New" or "Revised" License

139 stars 18 forks source link

Closed martinRenou closed 3 weeks ago

martinRenou commented 1 month ago

After applying an operator the boundinx boxes of the inputs are still visible:

I expected this not behave that way after putting the bounding box as part of the mesh group in https://github.com/jupytercad/JupyterCAD/pull/521, but it does.

Maybe we're not setting the visible property on the whole group.

martinRenou commented 1 month ago

Oh wait I guess it is the combination of two issues.

I see the two inputs are still selected on the left panel: the generated output should probably be selected after the operator is done instead
We should not create/show a bounding box for an object that's not visible

arjxn-py commented 1 month ago

thanks for opening this @martinRenou, the explanation helps already and will look more into it