search

jupytercalpoly / jupyterlab-richtext-mode

JupyterLab extension for rich text editing in the notebook
43 stars 18 forks source link

[WIP] Dark Mode Tweaks #35

Open bollwyvl opened 4 years ago

bollwyvl commented 4 years ago

Playing with this on binder: looking great!

With the stock JupyterLab dark theme, after highlighting a prosemirror and then selecting another cell, the unselected editor has white-on-white text. Screenshot from 2019-08-17 12-29-52

This just sets the background to transparent. Screenshot from 2019-08-17 12-31-03

Could use a var(--jp-, but it seems like less is probably more, if the goal is trying to make the editing experience feel seamless, this should be the most predictable across themes. Just unsetting it inherits some other styling which disappears when you actually select it. Not nice.

Will keep investigating some other things!

wip binder: Binder

isabela-pf commented 4 years ago

Thank you so much for working on this! I was just about to post an issue for all the dark mode mishaps, so I'll note that you're already fixing many of the problems I found.