search

jupytercalpoly / jupyterlab-richtext-mode

JupyterLab extension for rich text editing in the notebook
43 stars 18 forks source link

Remove Link button shows Make Link icon #36

Closed isabela-pf closed 5 years ago

isabela-pf commented 5 years ago

When a defined link is selected, the Link menu shows a button to remove the link. Even though the code shows the proper name to activate the icon via the Material icon font (link_off), it appears as the standard link icon we use for making and managing links (link). Obviously, this is a problem because it is not only confusing, but entirely incorrect information being sent to the user.

remove_link

A look into the material-design-icons repo makes me think it is because the icon font has not been updated recently. I found many issues (like this) referencing similar problems with different icons appearing than were described on the icon website.

isabela-pf commented 5 years ago

For now, we've switched to this updated version of the icon font to resolve this and a few other related issues. Since this alternative icon font is run by an individual, we should find a more reliable alternative for further implementation.

isabela-pf commented 5 years ago

Fixed in #28.