jupytercalpoly / jupyterlab-richtext-mode

JupyterLab extension for rich text editing in the notebook
43 stars 18 forks source link

Add tooltip to text formatting buttons #37

Closed isabela-pf closed 5 years ago

isabela-pf commented 5 years ago

The formatting buttons added through this extension are missing tooltips. This makes them inconsistent with other toolbar and buttons elsewhere in the interface, leads to poor user experience, and may impact accessibility.

It looks like JupyterLab currently labels tooltips with title (as is frequently recommended), but this may be a problem with the current implementation of icons via the Material Icons font.

isabela-pf commented 5 years ago

Though it was not a problem applying title to to the Material Icon font, we have switched to using svg files for our new icons. This is more in line with JupyterLab's current standards.

isabela-pf commented 5 years ago

Added in #28.