search

jupytercalpoly / jupyterlab-richtext-mode

JupyterLab extension for rich text editing in the notebook
43 stars 18 forks source link

fix missing markdown-it-mathjax npm package #39

Open alfonsoalongi opened 4 years ago

alfonsoalongi commented 4 years ago

Please add these fixes and undo and redo features

dLamSlo8 commented 4 years ago

Thank you for the contribution. We are currently testing it out and will get back to you as soon as possible.

dLamSlo8 commented 4 years ago

Upon reviewing this pull request, we've come to several conclusions and would like your opinion on them before we consider merging in the changes.

While we understand that undo and redo features are essential to the editor, we are unsure if they belong as buttons on the toolbar, as there is already a substantial amount of buttons existing there. We suggest adding undo and redo using just the appropriate keyboard shortcuts (Cmd/Ctrl + Z/Y). Eventually, these shortcuts will be exposed in a context menu so that users know they exist.

As for the list indentation, we feel that the same reasoning applies where there is already an excess of buttons. Also, we were wondering if your intentions were just for list indentation as opposed to indentation in all aspects of the editor? We would like to hear more about your reasoning behind this before we make final changes.

We appreciate your contribution thus far and want to continue with this discussion to nail down exactly what is wanted by the community. Thank you.