jupyterhealth / jupyter-health-software

A repository to track issues for the JupyterHealth Software Team
0 stars 0 forks source link

Questions about CommonHealth client credentials #11

Open minrk opened 2 months ago

minrk commented 2 months ago

@surfdoc has provided me with credentials for Jupyter Health and Jupyter Health Testing.

I've placed the two sets of credentials as KV pairs in aws secretmanager in our aws project: ch-health-creds-[prod|testing].

My questions so far are about credentials and their lifetimes/lifecycles

What I'm trying to get at is what does "Jupyter Health" have access to, vs what does an individual Hub user have access to, and how can/should they differ (e.g. subsets of keys or shared keys, etc.). This will affect what credentials we load into the Hub user environment, and the presumably custom StorageDelegate class that we will use, because SQLite isn't going to work for shared state. For example, I see these broad categories:

  1. single shared storage delegate for everyone on the Hub. Necessarily means everyone has access to all data associated with a given partner
  2. each user has entirely their own storage delegate, not shared with anyone else - no users can access data created by another
  3. 'project'-level, where there is more than one storage delegate, where each user has access to one or more storage delegates, and each delegate may be accessible to one or more users

Which of these best represents the credential/access patterns we expect here? In particular, does 3. make sense where a single 'partner' might have different users with different access scopes, or does this generally mean creating a new 'partner', and keys should be considered an implementation detail?

surfdoc commented 2 months ago

@minrk

minrk commented 2 months ago

Got it, then I think I know what we need to do for pre-MVP on our side:

surfdoc commented 2 months ago

Sounds great. Once we have the SoF auth server integrated with CHCS and in a testable state I will reach out and we can begin testing the better auth flow.