Drop backwards compatibility to jupyterhub==0.9.6 and python==3.5

jupyterhub / batchspawner

Custom Spawner for Jupyterhub to start servers in batch scheduled systems

BSD 3-Clause "New" or "Revised" License

190 stars 134 forks source link

Drop backwards compatibility to jupyterhub==0.9.6 and python==3.5 #142

Closed rkdarst closed 5 years ago

rkdarst commented 5 years ago

As agreed during Jupyterhub for research facilities sprint.
For now, test PR to see what works on Travis currently.

rkdarst commented 5 years ago

Nice, all tests pass now by default when we drop the old versions. Upcoming commit will clean up a bit then I guess this is ready to go.

Can someone kick travis to re-run tests on important old PRs? My own PRs, I'll rebase.

rkdarst commented 5 years ago

Passes - can someone merge?

rkdarst commented 5 years ago

Note: accepting this will begin testing on 1.0, which requires some previous key PRs to also be changed. I am working on an integration of them all that works.

rkdarst commented 5 years ago

Thanks!

Could you accept https://github.com/jupyterhub/wrapspawner/pull/27? That will be required for upcoming fixes to batchspawner, and better to do that first than work around.

rkdarst commented 5 years ago

Actually maybe not strictly needed for the general case without wrapspawner...