jupyterhub / batchspawner

Custom Spawner for Jupyterhub to start servers in batch scheduled systems
BSD 3-Clause "New" or "Revised" License
190 stars 134 forks source link

Update batchspawner.py to use --chdir instead of --workdir #165

Closed yfoo closed 4 years ago

yfoo commented 5 years ago

Switched --workdir in the slurm section to be --chdir instead. Slurm 19.05 series removed the --workdir option.

rkdarst commented 4 years ago

Looks good, in Slurm since 17.11 so that's not very old but not too new either. I tried to add a changelog entry, but could'nt push to here. I'll add it in my upcoming integration branch. Thanks!

welcome[bot] commented 4 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: