search

jupyterhub / batchspawner

Custom Spawner for Jupyterhub to start servers in batch scheduled systems
BSD 3-Clause "New" or "Revised" License
190 stars 134 forks source link

add 'gres' option to SlurmSpawner #170

Closed Hoeze closed 4 years ago

Hoeze commented 4 years ago

As the name tells, it allows to specify e.g. GPU requests

rkdarst commented 4 years ago

We could debate if we should not add a specific option for everything, since the generic req_options works, too. What do others think?

But since this is here, --gres seems to be rather important anyway (if people go more towards GPUs) so why not. I will add an entry to the changelog and add it to my integration branch.

rkdarst commented 4 years ago

I added a test, I think this is good to go.

mbmilligan commented 4 years ago

We may want to revisit the larger policy around proliferating options and requests to change defaults, but for now this seems both sufficiently generic and well-motivated to accept.