unknown job state: Improvements of #179 to make tests pass

rkdarst commented 4 years ago

As mentioned there, I am following up in a new PR since I don't know if I should edit that one.
Remaining suggestions from there are applied
Make tests pass, the key commit is https://github.com/rkdarst/batchspawner/commit/c81298d8acd67550a9bdeaed547c6e45dda2254f (which I'd recommend that people review if they want to review anything)
Add further tests for the unknown job state.
Closes: #179, #178, #174, #171
This took a lot of work and hand-drawn diagrams to understand the exact spawning process, but I think I got it and it matches the behavior expected by JupyterHub. But I encourage anyone with deeper wisdom to take a look.

Hoeze commented 4 years ago

Thanks for putting so much effort into this. Is this patch complete + useable yet?

mbmilligan commented 3 years ago

Discussed in monthly meeting, plan to merge now and create RC feature release after some testing.

jupyterhub / batchspawner