search

jupyterhub / batchspawner

Custom Spawner for Jupyterhub to start servers in batch scheduled systems
BSD 3-Clause "New" or "Revised" License
190 stars 134 forks source link

version.py missing from pypi source package #197

Closed ebirn closed 3 years ago

ebirn commented 3 years ago

Hi all,

Bug description

trying to build batchspawner from source, version.py is missing in pypi download .tar.gz

Wheel installation via pip is fine. Github tagged version 1.0.0 also contains version.py Possible cause is the python sdist is missing the version.py as it is on the root directory of repo (when called in the github action)

Expected behaviour

pip install completes without error

Actual behaviour

# basically running
pip install --prefix=/software/2020/software/jupyter-cbe-env/0.1.0-foss-2018b  --no-deps  --ignore-installed  --no-build-isolation 

#
== 2020-12-02 15:54:23,175 build_log.py:169 ERROR EasyBuild crashed with an error (at easybuild/4.2.0/lib/python2.7/site-packages/easybuild/base/exceptions.py:124 in __init__): cmd " pip install --prefix=/software/2020/software/jupyter-cbe-env/0.1.0-foss-2018b  --no-deps  --ignore-installed  --no-build-isolation  ." exited with exit code 1 and output:
Processing /software/build-tmp/JupyterCBEenv/0.1.0/foss-2018b/batchspawner/batchspawner-1.0.1
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/eb-egMDIg/pip-req-build-i9lozl3d/setup.py", line 24, in <module>
        with open(pjoin(here, 'version.py')) as f:
    FileNotFoundError: [Errno 2] No such file or directory: '/tmp/eb-egMDIg/pip-req-build-i9lozl3d/version.py'

How to reproduce

build pypi from source, or inspect downloaded .tar.gz

Your personal set up

Using the Easybuild build system on CentOS 7.9, with Python 3.6.6, basically running

Best, Erich

welcome[bot] commented 3 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada: