jupyterhub / batchspawner

Custom Spawner for Jupyterhub to start servers in batch scheduled systems
BSD 3-Clause "New" or "Revised" License
190 stars 134 forks source link

Improve submit_batch_script logging #219

Closed cmd-ntrf closed 8 months ago

cmd-ntrf commented 3 years ago

Adds:

Changes:

The rational is that it is easier to parse subvars dictionary in a separate log than the multiline submit script, which would then be only useful in a debug context.

Removes:

This PR also introduces the usage of logging argument instead of concatenating string with +. I will follow with a second PR that standardize logging to use argument instead of string concatenation systematically.

mbmilligan commented 2 years ago

Hi, after we update the test matrix can you make a commit to this to trigger rerunning the CI?

consideRatio commented 8 months ago

This looks reasonable, thank you @cmd-ntrf!