Replace `scripts` with `console_scripts` - Githubissues

jupyterhub / batchspawner

Custom Spawner for Jupyterhub to start servers in batch scheduled systems

BSD 3-Clause "New" or "Revised" License

190 stars 134 forks source link

Replace `scripts` with `console_scripts` #235

Closed nrbgt closed 2 years ago

nrbgt commented 2 years ago

Proposed change

While this package doesn't require being entirely cross-platform, use of scripts is more portable and better managed on different downstreams.

Alternative options

Keep using scripts.

Who would use this feature?

Downstream packagers, such as conda-forge can reason

(Optional): Suggest a solution

Likely, need to

replace
- scripts="scripts=glob(pjoin("scripts", "*")) with
- entry_points=dict(console_scripts=["batchspawner-singleuser=batchspawner.singleuser:main"])
delete scripts/ (and any references in other files, etc)

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada: