Replace use of scripts with entry_points

jupyterhub / batchspawner

Custom Spawner for Jupyterhub to start servers in batch scheduled systems

BSD 3-Clause "New" or "Revised" License

190 stars 134 forks source link

Replace use of scripts with entry_points #237

Closed bollwyvl closed 2 years ago

bollwyvl commented 2 years ago

References

fixes #235

Changes

[x] replaces use of scripts with entry_points: console_scripts
- this generally generates better/more secure scripts that are more predictable for downstream packagers e.g. debian, conda-forge
- also more cross-platform-compatible, which is a story for another day...

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

bollwyvl commented 2 years ago

Here's the corresponding PR on jupyterhub itself:

https://github.com/jupyterhub/jupyterhub/pull/2313

consideRatio commented 2 years ago

Nice that makes me quite confident this is good to go, I'll go for a merge if this grows stale.

Btw, test failures are unrelated and fixed by #241.

consideRatio commented 2 years ago

Given that this pattern was demonstrated sensible in jupyterhub without other changes needed and the PR seemed to go stale I'll go for a merge on this now that also all tests has passed by fixing it in other PRs.