search

jupyterhub / batchspawner

Custom Spawner for Jupyterhub to start servers in batch scheduled systems
BSD 3-Clause "New" or "Revised" License
190 stars 134 forks source link

Update test matrix #248

Open ryanlovett opened 2 years ago

ryanlovett commented 2 years ago

Proposed change

Update text matrix to be more inline with jupyterhub and in-use distributions.

247 was failing in python 3.5 but not 3.9. I saw that 3.5 had not been supported in JupyterHub for a while so asked whether 3.5 could be dropped. @mbmilligan said:

So yes, I think I'm okay with dropping testing support for Python 3.5. I wouldn't drop 3.6 support for a while yet though. As that's currently the newest Python that can easily be installed on those CentOS 7 systems, I think we're stuck with it until those systems go EOL in 2024.

This suggests changing the oldest version batchspawner supports from 3.5 to 3.6.

Alternative options

Do nothing, and ensure future PRs are compatible with python 3.5 too.

Who would use this feature?

Contributors who don't want to support older pythons.

(Optional): Suggest a solution

Should the matrix be expanded to support everything JupyterHub does, plus 3.6? That is, batchspawner's tests are on 3.5 and 3.9 right now, so should the set be 3.6 and 3.9, or 3.6 .. 3.11 ?

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

willfurnass commented 1 year ago

NB folks still on EL7 can get Python 3.8 from the rh-python3.8 RedHat Software Collection (more info).