search

jupyterhub / batchspawner

Custom Spawner for Jupyterhub to start servers in batch scheduled systems
BSD 3-Clause "New" or "Revised" License
190 stars 134 forks source link

poll job status while waiting for single-user server to be reachable #254

Closed lexming closed 8 months ago

lexming commented 1 year ago

Fixes #253

Poll job status while waiting to get the port back from the single-server to catch any failure in the job before the server launches.

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

ryanlovett commented 1 year ago

This worked for me when I intentionally added an exit 1 to our form's prologue field.

This was to simulate early failures that jupyterhub will otherwise miss. When it happens, the user cannot start the server because jupyterhub thinks it is already running. This might not be a problem for deployments with short timeouts -- the user can just wait. However we have long timeouts to match those for non-interactive activity. This will be very helpful for us.

opoplawski commented 1 year ago

This would be very helpful.

consideRatio commented 8 months ago

This PR looks relevant even today, so I rebased this PR to resolve merge conflicts and get it to run against current tests. They are failing currently though =/

welcome[bot] commented 8 months ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: