Fix Slurm test used regular expression

jupyterhub / batchspawner

Custom Spawner for Jupyterhub to start servers in batch scheduled systems

BSD 3-Clause "New" or "Revised" License

187 stars 132 forks source link

Fix Slurm test used regular expression #256

Closed t20100 closed 6 months ago

t20100 commented 1 year ago

This PR fixes the regular expressions used to validate the submitted batch script.

Indeed according to re.X documentation:

When a line contains a # that is not in a character class and is not preceded by an unescaped backslash, all characters from the leftmost such # through the end of the line are ignored.

So all regular expressions were matching to the line start.

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] commented 6 months ago

Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart:

consideRatio commented 6 months ago

Thank you for the clear motivation for the change @t20100!