jupyterhub / batchspawner

Custom Spawner for Jupyterhub to start servers in batch scheduled systems
BSD 3-Clause "New" or "Revised" License
190 stars 134 forks source link

Add a way to configure SLURM `#SBATCH --output` #257

Open t20100 opened 1 year ago

t20100 commented 1 year ago

Proposed change

It would be nice to allow the configuration of the --output sbatch parameter the same way as for other parameters. This would enable customisation of the output file as well as passing /dev/null to silent SLURM output.

Alternative options

Leave it as it is: --output={{homedir}}/jupyterhub_slurmspawner_%j.log

Who would use this feature?

I'm already using a similar feature in jupyterhub_moss, a customized SLURM Spawner (See https://github.com/silx-kit/jupyterhub_moss/blob/fbcf07c7b7198af97e8cd3545458759e5e882b9e/jupyterhub_moss/batch_script.sh#L13), but this requires duplicating the batch_script.

(Optional): Suggest a solution

Add a req_output to SlurmSpawner (see #258).

welcome[bot] commented 1 year ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada: