search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

image: use tini to react on SIGTERM for quick terminations #1421

Closed consideRatio closed 2 years ago

consideRatio commented 2 years ago

I know the binder pod is slow to terminate without this, and I know the binder pod is quick to terminate with this - so somehow the SIGTERM signal is lost without it. I can't say for sure why, but that's the case.

Let's go with it, and if someone can make it optimized to not need tini for this purpose, we can switch to that later.

minrk commented 2 years ago

I'd love to understand why! tini really shouldn't be needed for this, but it's good to have it fixed anyway.