remove custom `dependencies` script in place of plain pip-compile

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!

https://binderhub.readthedocs.io

BSD 3-Clause "New" or "Revised" License

2.54k stars 388 forks source link

remove custom `dependencies` script in place of plain pip-compile #1433

Closed minrk closed 2 years ago

minrk commented 2 years ago

greatly simplifies and speeds up updates. Solves dependabot confusion in #1430

The custom dependencies script from z2jh solves issues with e.g. build-arg specified jupyterhub versions, that we don't have here.

The only problem we need to solve here is Python version + OS + arch match, which can be addressed with a simpler run in python:3.8 in docker (or just run pip-compile on the host, for folks already using Python 3.8 on x86_64 Linux).

minrk commented 2 years ago

I think #1434 may solve the test failure

yuvipanda commented 2 years ago

Thanks, @minrk!