jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

How do the auth_enabled and cors_allow_origin values initiated? #1438

Open emrahkaya opened 2 years ago

emrahkaya commented 2 years ago

The parameters for the BinderSpawnerMixin class don't get initialized in my tests.

In the previous versions of the chart, those values were explicitly read into global variables:

cors = z2jh.get_config('custom.cors', {})
auth_enabled = z2jh.get_config('custom.binderauth_enabled', False)

But now it is not clear how these values are initialized. And in my case, they are not initialized using the values from the values.yaml either. Please help.

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada: