search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

Fix Ingress API check #1443

Closed emrahkaya closed 2 years ago

emrahkaya commented 2 years ago

If the full API resource is given, Helm on ArgoCD produces wrong answer for the ".Capabilities.APIVersions.Has" template. Checking for "networking.k8s.io/v1" is enough, and works well.

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

consideRatio commented 2 years ago

There is a version issue for argo's helm library in my mind. They should use a more modern version. Z2jh require helm 3.5 and that can handle this.

Due to that i wish to reject this PR, i think there are more issues to follow if this would be patched anyhow, and this was just the first of several issues if using an old helm version.

I suggest making sure you use the latest argo version, and then nudging argo to use a more modern version of helm (3.5+ needed).