search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

Display error message to the user when max number of named servers is reached #1469

Open viktoriaas opened 2 years ago

viktoriaas commented 2 years ago

Bug description

Hi, I've recently noticed that our instance of binderhub does not show correct error messages to user. Particularly, if user has reached the maximum of configured named servers, the displayed error is just generic Failed to launch image ...

I found the same issue #1022 and also a discussion at discourse. We run a newer version of binderhub than #1022 introduces. User ckarwicki says in discourse post they use OAuth for authentication which we also do (GenericOAuthenticator).

Expected behaviour

The user is presented the correct error message `User [XXX] already has the maximum of 5 named servers. One must be deleted before a new server can be created.

Actual behaviour

User sees just a generic message Failed to launch image ... that does not lead him anywhere and has to contact user support although the error is very specific and should be seen.

MicrosoftTeams-image

Your personal set up

For the actual binderhub Pod, we have a custom image that only adds 2 directories and image is built on jupyterhub/k8s-binderhub:0.2.0-n868.h48bc0f6

(Image dockerfile: 

FROM jupyterhub/k8s-binderhub:0.2.0-n868.h48bc0f6                               
RUN mkdir -p /etc/binderhub/custom/templates && mkdir -p /etc/binderhub/custom/static

)

Logs

Relevant logs from binderhub Pod where you can see that correct error message appears 4 times before server get Internal Server Error 500.

Screenshot 2022-04-08 at 13 23 15
welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

florian-jaeger commented 1 month ago

+1 this really hurts the user experience