search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

Using escaped username in progress api call affecting launch of serve… #1516

Closed pedroosorio closed 1 year ago

pedroosorio commented 2 years ago

Hi,

This PR aims to solve launch issues where binderhub would call the server progress api with an unescaped username, causing a 400 Bad Request to be thrown by the server. In turn, this would fail the server execution and launch another server, up to a maximum of 4 server. This behavior should also be addressed, in another PR.

Signed-off-by: Pedro Osório pedro.osorio@atlar.pt

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

piersharding commented 2 years ago

Hi, this would be super helpful at the SKAO, as we have an internationalised user base. Thanks, Piers Harding.

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

piersharding commented 1 year ago

Thanks for processing this - Cheers.