search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

Should k8s-binder-k8s-hub/binderhub-chart-config-old.yaml be kept or deleted? #1520

Open manics opened 2 years ago

manics commented 2 years ago

k8s-binder-k8s-hub/binderhub-chart-config-old.yaml says it should be deleted: https://github.com/jupyterhub/binderhub/blob/7fa1d77f5d82ec60e05e2ef4ecd6e92950d2b87e/testing/k8s-binder-k8s-hub/binderhub-chart-config-old.yaml#L1-L2 However it's referenced in the CI workflows: https://github.com/jupyterhub/binderhub/blob/7fa1d77f5d82ec60e05e2ef4ecd6e92950d2b87e/.github/workflows/diff.yml#L54-L59 https://github.com/jupyterhub/binderhub/blob/7fa1d77f5d82ec60e05e2ef4ecd6e92950d2b87e/.github/workflows/test.yml#L185-L190

Should it be kept and the comment removed, or should the file and all references to it be deleted?

consideRatio commented 1 year ago

I recognize the need for having two sets of helm chart configuration because the CI system tests against an old version and then upgrades to a new version etc. I presume this is about that, and that we can now remove everything related to it.

@minrk you added the DELETE ME note, do you agree on deleting the file and all logic referencing it?