search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

Add automation to refreeze and update google-cloud-logging from v1 to v3 #1536

Closed consideRatio closed 2 years ago

consideRatio commented 2 years ago

While this PR aimed to only add automation to refreeze etc, I found that it fails unless updating google-cloud-logging as pip-compile concluded we had incompatible versions otherwise.

The code that could risk breaking when updating google-cloud-logging resides in mybinder.org-deploy rather than in this repo. But, I don't think it will break based on reading the migration guide.

This may have influenced the logs emitted, but maybe not? =/ Unsure.

With 3.0.0, when a log doesn't specify a monitored resource, the library attempts to identify the resource. If a resource can't be detected, the field will still default to "global".

welcome[bot] commented 2 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: