search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.56k stars 390 forks source link

Change component name from dind to image-builder #1543

Closed sgaist closed 2 years ago

sgaist commented 2 years ago

In parallel of the work from #1531, this change will allow the use of other builders than Docker without being tied to its nomenclature which might make the whole a bit confusing when deploying and debugging.

Part of #1513

consideRatio commented 2 years ago

I'm not sure, about tooling relying on identifying the pods by the component: dind label. Maybe grafana dashboards etc or some maintenance scripts in mybinder.org-deploy?

I looked but found nothing. Seems reasonable to me!

I wonder if upgrading to this binderhub version will make the active build pods be abandoned or similar? If so its good that such notes are part of the PR description so that upgrades can be made during low load at least.

minrk commented 2 years ago

Yeah, if anything I would guess it's only something in grafana or possibly a network policy.

manics commented 2 years ago

Thanks all, merging!