search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

Improve BinderHub page Accessibility #1559

Closed bl-aire closed 1 year ago

bl-aire commented 1 year ago

Haven accessed BinderHub page using WAVE and axe accessibility tools stated in the microtask, I have implemented changes based on my solutions proffered in the issue which are geared towards improving the accessibility of BinderHub page.

This PR does the following:

  1. Add alt text to images via the alt attribute alt="example text".
  2. Add the lang attribute to the opening html tag <html lang="en>".
  3. Improve contrast between selected text and their background colors.
  4. Fix missing first level heading.

More details about the changes made can be found in issue #57

bl-aire commented 1 year ago

Wonderful, thank you! I've added some comments.

Let me know if you need a hand on the screenshot.

Thanks for the review. I'll implement changes mentioned

I had issues with locating the links and donate button in the header. Please can you help me with that?

minrk commented 1 year ago

I had issues with locating the links and donate button in the header. Please can you help me with that?

Yes! Those are not actually in this repo. They are added specifically for mybinder.org here

bl-aire commented 1 year ago

I had issues with locating the links and donate button in the header. Please can you help me with that?

Yes! Those are not actually in this repo. They are added specifically for mybinder.org here

Okay. I spent hours looking for it 😅

Thank you

minrk commented 1 year ago

Thank you, @bl-aire!

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: