Closed manics closed 1 year ago
This segment seems like a bug, or it is at least a notable issue because its simply separate from providing config.BinderHub.build_docker_config
in values. Whats under .config
should be pure passthrough - so buildDockerConfig won't map to build_docker_config.
So currently, either:
config.BinderHub.buildDockerConfig
, if that specific value is provided.config.BinderHub.build_docker_config
set, but the impact of doing that is trivial - it will just make an explicitly set push_secret
be consumed if also use_registry
is False.Something or multiple things are wrong for sure.
If we can reduce the complexity of this, that would be great - to me this seems bugged overall, so a breaking change would be acceptable in my mind as a bugfix.
@manics I changed the maintenance label to a documentation label as this PR was pure documentation/inline comments - even though its documentation related to maintenance efforts. Feel free to switch back, i see upsides with either approach!
I have leaned towards labelling PRs as documentation if no code change, guided by the idea that it makes it easier to dismiss the PR as something that couldn't possibly have caused a regression or a change in behavior etc.
This was added in https://github.com/jupyterhub/binderhub/pull/1255
As far as I can see the value of
c.BinderHub.build_docker_config
isn't used by the BinderHub Python app, only it's presence is checked:Instead it's used in the Helm Chart secret: https://github.com/jupyterhub/binderhub/blob/2ba938bf20201ff864b3a6c473f66f30fbef92bc/helm-chart/binderhub/templates/secret.yaml#L34-L42
This adds a warning message to help avoid confusion.
Note I don't understand the Helm chart code.... the secret refers to
config.BinderHub.buildDockerConfig
instead ofconfig.BinderHub.build_docker_config
.