jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

Fix auth docs config (again) #1599

Closed manics closed 1 year ago

manics commented 1 year ago

The value of oauth_client_id doesn't matter, but it's needed, otherwise you'll get

400 : Bad Request
Missing client_id parameter.

Omitting namedServerLimitPerUser fails because BinderHub ends up calling int("") and fails: https://github.com/jupyterhub/binderhub/blob/1b040a654c79b01c9a6d56c04b19aa905281146d/helm-chart/binderhub/templates/deployment.yaml#L138-L143

I'm going to try and add a proper Helm test in a separate PR since we don't have a proper test for this config.