search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

Test dind and pink #1602

Closed manics closed 1 year ago

manics commented 1 year ago

We currently test 3 Helm chart configurations. This means we can test all three imageBuilderType without increasing the number of matrix items.

Currently we only test host, but since docker is no longer part of Kubernetes most production deployments will use dind (or similar) so I think we should test it as standard even though it means deploying a registry.

When building images with chartpress we can use localhost since it's running outside K8s, but we need to use the hosts's external IP ($REGISTRY_HOST) when referring to images from inside K8s.

(extracted from https://github.com/jupyterhub/binderhub/pull/1521)

consideRatio commented 1 year ago

Wow it seems like a lot of effort went into this given the complexity of it. Thank you for your work @manics!!!!

manics commented 1 year ago

Thanks for reviewing!