search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

route to offlinenotebook #1604

Closed dg-data closed 1 year ago

dg-data commented 1 year ago

Bug description

jupyter-offlinenotebook extension fails to initialize

Expected behaviour

Actual behaviour

How to reproduce

(https://mybinder.org/v2/gh/rwcitek/MyBinder.dockerfile/HEAD?urlpath=offlinenotebook%2Fconfig) results to 404 error Using other github repos, without a Dockerfile to build from, I can save notebooks to browser storage.

Your personal set up

welcome[bot] commented 1 year ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

manics commented 1 year ago

jupyter-offlinenotebook isn't installed in your Dockerfile: https://github.com/rwcitek/MyBinder.dockerfile/blob/main/Dockerfile

If you need more help please use the Jupyter community forum https://discourse.jupyter.org/

dg-data commented 1 year ago

According to this post, installation of the extension is automatic.

We have added a few new buttons to the toolbar of the notebook on mybinder.org It will be automatically installed when you (re)build your repository. Try it out with one of our demo repositories.

Building from Dockerfile, installation of the extension is needed. After all it works, but I think it's poorly documented(?)

example with Dockerfile: https://mybinder.org/v2/gh/paveloom-d/binder-base/master?urlpath=offlinenotebook/config