Closed manics closed 1 year ago
Is there no way to get a GH token that is limited in scope to "read public repos" to increase the rate limit? I'm thinking a token that doesn't give the PR any new permissions except for raising the rate limit.
Maybe we can use secrets.github_token? I think that is around and provides read only access to stuff even when run in PRs. I'm not sure though, and I'm not sure it would work even if it is etc.
Maybe the tests are less frequently failing now, but I've seen that they can still fail sadly.
We should be able to record and re-use mock responses to avoid so many API calls, right? I think we do some of that already, but perhaps we've added more API calls without adding the recorded responses.
Bug description
binderhub/tests/test_build.py
often fails with the errorI think this is related to how often PRs are opned and updated, the required timeout can easily reach 60 minutes
Expected behaviour
GitHub API limits are only occasionally reached for PR workflows
Actual behaviour
Limits are often hit, causing CI tests to incorrectly fail.
How to reproduce
I think opening a PR that runs all tests, and updating if several times, is enough.
I think we should go through the tests and minimise the number of live GH API calls. Note we shouldn't use a GitHub API token since these are PRs.