breaking: require Python 3.8, from Python 3.6

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!

https://binderhub.readthedocs.io

BSD 3-Clause "New" or "Revised" License

2.57k stars 390 forks source link

breaking: require Python 3.8, from Python 3.6 #1610

Closed consideRatio closed 1 year ago

consideRatio commented 1 year ago

breaking: require Python 3.8, from Python 3.6
pre-commit: run with pyupgrade --py38-plus

manics commented 1 year ago

Do you mind adding this breaking change to https://github.com/jupyterhub/binderhub/blob/main/CHANGES.md#breaking-changes ?

manics commented 1 year ago

On second thoughts, let's leave the breaking changes doc till after all these https://github.com/jupyterhub/binderhub/labels/breaking PRs are merged to avoid dealing with conflicts.... just need to remember :smile: (edit: didn't realise pasting a URL to a label displays the label in-line!)

consideRatio commented 1 year ago

On second thoughts, let's leave the breaking changes doc till after all these breaking PRs are merged to avoid dealing with conflicts...

Yepp I was thinking the same thing!

Thanks for your review!!

ofek commented 1 year ago

Hello! Just FYI now that 3.6 is no longer supported Hatchling can be used as the build backend. cc @blink1073 to confirm

blink1073 commented 1 year ago

Yes, that is true, using hatch-jupyter-builder's migration script.