search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

ci: set GITHUB_ACCESS_TOKEN to temporary read only token #1612

Closed consideRatio closed 1 year ago

consideRatio commented 1 year ago

We ran into rate limitations, but by setting the env var GITHUB_ACCESS_TOKEN in our GitHub Job's, which is the default value for c.GitHubRepoProvider.access_token, this is no longer an issue.

We still have to mock tests with GistRepoProvider as the secrets.github_token is not provided rights to access api.github.com/gists.

Remaining test failure is resolved by #1615

manics commented 1 year ago

I started looking last night, saw a massive JSON blob.... and decided to leave it 😄. Everything else looked fine though, so happy to go with @betatim

consideRatio commented 1 year ago

Ah sorry about the JSON blob. I wrote about it but then felt my PR description ended up so long that it was boring to read through and removed my notes about it ^^

The JSON changes is two keys representing api.github.com/gists URLs that are to be mocked that I relocated from one file to a standalone file. In other words, its just one file split in two.

Thanks for reviewing this, I'll go for a merge!

consideRatio commented 1 year ago

I spotted a typo in this PR so the issue wasn't resolved. I added a commit fixing that typo in #1615 now though.