jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

Support dynamic registry tokens, add wrapper for working with registry microservice #1637

Open manics opened 1 year ago

manics commented 1 year ago

This is a companion for https://github.com/jupyterhub/repo2docker/pull/1245 that allows dynamic credentials t be used for pushing to a registry. This is required for e.g. ECR where the token used to login to the reigistry expires.

This also implements the non-vendor specific parts of https://github.com/jupyterhub/binderhub/issues/1623

Closes https://github.com/jupyterhub/binderhub/issues/705

You can see an example implementation of the microservice side in https://github.com/manics/binderhub-container-registry-helper This is working with AWS ECR using an IRSA role for the microservice.

It's written in Go as I wanted to learn it, but if we choose to pursue this rewriting it in Python (or Javascript, or any other language) shouldn't be too difficult.

manics commented 1 month ago

Anyone else have thoughts on this? @stevejpurves is interested in using it.