search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

helm-chart: refactor Dockerfile to make it obvious we don't fail to pass built wheels #1638

Closed consideRatio closed 1 year ago

consideRatio commented 1 year ago

I think we actually built the wheel for grpcio correctly in the build-stage, and that was transferred, but I hesitated on that when I saw changes compared to a Dockerfile in z2jh.

With this, I'm making the Dockerfiles align, but in practice the reason for #1636 is that it takes ages to build grpcio on arm64 where they don't have a wheel published.

consideRatio commented 1 year ago

Self merging as this now conflicts with #1648 so I can rebase that on this