jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.57k stars 390 forks source link

maint: refactoring around pycurl as an optional dependency #1648

Closed consideRatio closed 1 year ago

consideRatio commented 1 year ago

I saw an opportunity to reduce the complexity a bit by relying more on the optional dependency declared in setup.py on pycurl over specifying it separately. This would be especially relevant if we would enforce a version constraint on pycurl in setup.py.

We couldn't reduce the complexity that much since binderhub is installed locally. This is always tricky since requirements.in freezes into requirements.txt using pip-compile via the ci/refreeze script, and when it does we get an absolute path to install binderhub. And with that, I think we can't avoid issues when we are to install pre-built wheels in the Dockerfile.

consideRatio commented 1 year ago

I've done a delayed self-review, and think it makes sense still as it is. I'll go for a self-merge in the intrest of minimizing use of our limited maintenance capacity.