jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

maint: bump xterm and xterm-addon-fit #1655

Closed consideRatio closed 1 year ago

consideRatio commented 1 year ago

This PR bumps the package.json's dependencies and devDependencies. Since we don't have a package-lock.json, the ^ means that in practice we are using the latest major version before and after this change for all packages except for those listed below. I've manually read through these changelogs and searched our code base for something breaking without finding anything.

dependencies:

devDependencies:


manics commented 1 year ago

Have you already manually verified the UI works (https://binderhub.readthedocs.io/en/latest/contribute.html#develop-user-interface) or does this still need to be checked?

consideRatio commented 1 year ago

No, I'll check!

consideRatio commented 1 year ago

Thanks @manics for helping me test this easily!

I've verified things look as usual:

The failure seen is because I've not started a jupyterhub to launch etc, but the terminal looks fine and like before.

image

consideRatio commented 1 year ago

Thanks for the review @manics and @sgibson91!!