search

jupyterhub / binderhub

Run your code in the cloud, with technology so advanced, it feels like magic!
https://binderhub.readthedocs.io
BSD 3-Clause "New" or "Revised" License
2.54k stars 388 forks source link

maint: Prompt check of public repo during ref resolution #1659

Closed matthewfeickert closed 1 year ago

matthewfeickert commented 1 year ago

Resolves #1658

Instead of prompting the user to check if the URL for their repo is public only if it is not on GitHub and if all other resolution has failed, escalate prompting the user to check if the repo is public as soon as there are ref resolution problems.

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

matthewfeickert commented 1 year ago

(Rebased to bring in the pre-commit fix as a fixup to avoid extra commit noise. Sorry for any noise.)

matthewfeickert commented 1 year ago

@consideRatio as it looks like you're the current maintainer this is passing CI and ready for review. :+1:

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: